Adds Spaces and Chat badges to countImportant #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to all y'all for this recipe! I use it with G-Suite and have missed a few important messages from only seeing Ferdium count emails and not chat messages.
mcmxcdev
approved these changes
Dec 15, 2023
Comment on lines
+8
to
+9
| "node": "^20.9.0", | ||
| "pnpm": "^8.10.0" |
There was a problem hiding this comment.
That's not really a change that should be part of this PR scope, but I am fine with it.
|
awesome stuff! Thanks! |
rdwz
reviewed
Dec 19, 2023
| }, | ||
| "volta": { | ||
| "node": "20.9.0", | ||
| "pnpm": "8.10.0" | ||
| "node": "^20.9.0", |
There was a problem hiding this comment.
Volta v1.1.1
Could not parse version "^20.9.0"
Please verify the intended version.
Error cause: encountered unexpected token: Caret
There was a problem hiding this comment.
Ugh was mixing it up with engines, good point I will change this back later.
| "node": "20.9.0", | ||
| "pnpm": "8.10.0" | ||
| "node": "^20.9.0", | ||
| "pnpm": "^8.10.0" |
There was a problem hiding this comment.
error: Could not parse version "^8.10.0"
Please verify the intended version.
Error details written to /home/node/.volta/log/volta-error-2023-12-19_19_42_57.805.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to all y'all for this recipe!
I use it with G-Suite and have missed a few important messages from only seeing Ferdium count emails and not chat messages.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Makes the badge account for chat messages from DMs and Spaces.
Also, unlocks version lock. I ran everything just fine with Node 20.10.0 and pnpm 8.12.1