emit signal with no arguments, for being able to safely connect with …

…slot with arguments by value Fixes root-project#7195
ferdymercury · Feb 16, 2021 · a6fdb1d · a6fdb1d
1 parent a3c0cc5
commit a6fdb1d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/gui/gui/inc/TGComboBox.h b/gui/gui/inc/TGComboBox.h
@@ -143,6 +143,7 @@ class TGComboBox : public TGCompositeFrame, public TGWidget {
    virtual void Selected(Int_t widgetId, Int_t id);                  // *SIGNAL*
    virtual void Selected(Int_t id) { Emit("Selected(Int_t)", id); }  // *SIGNAL*
    virtual void Selected(const char *txt) { Emit("Selected(char*)", txt); } // *SIGNAL*
+   virtual void Selected() { Emit("Selected()"); } // *SIGNAL*
    virtual void ReturnPressed();                                     // *SIGNAL*
    virtual void SavePrimitive(std::ostream &out, Option_t *option = "");
 

diff --git a/gui/gui/src/TGComboBox.cxx b/gui/gui/src/TGComboBox.cxx
@@ -464,6 +464,7 @@ void TGComboBox::Select(Int_t id, Bool_t emit)
          if (emit) {
             Selected(fWidgetId, id);
             Selected(id);
+            Selected();
          }
       }
    }
@@ -609,6 +610,7 @@ Bool_t TGComboBox::ProcessMessage(Long_t msg, Long_t, Long_t parm2)
                }
                Selected(fWidgetId, (Int_t)parm2);
                Selected((Int_t)parm2);
+               Selected();
                fClient->NeedRedraw(this);
                break;
          }
@@ -621,7 +623,7 @@ Bool_t TGComboBox::ProcessMessage(Long_t msg, Long_t, Long_t parm2)
 }
 
 ////////////////////////////////////////////////////////////////////////////////
-/// Emit signal.
+/// Emit signal, done only when selected entry changed.
 
 void TGComboBox::Selected(Int_t widgetId, Int_t id)
 {