Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async can't utilize KanalPtr as effective as Sync #22

Closed
fereidani opened this issue Nov 17, 2022 · 1 comment
Closed

Async can't utilize KanalPtr as effective as Sync #22

fereidani opened this issue Nov 17, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed performance

Comments

@fereidani
Copy link
Owner

With the addition of KanalPtr with 92c8f58 and 65e9102 we got these performance gains for SPSC benchmark for usize bounded(0) channel:
sync_kanal 1333923 messages per second
sync_pre7 920740 messages per second
sync_gain 30.98
async_current 9843154 messages per second
async_pre7 9723400 messages per second
async_gain 1.22

as you can see we got a 31 percent performance boost in sync but only 1 percent for async.
I need some help reviewing the async part to find out why we didn't receive a similar gain as sync.

@fereidani fereidani added enhancement New feature or request help wanted Extra attention is needed performance labels Nov 17, 2022
@fereidani
Copy link
Owner Author

The problem is solved with the new implementation of the signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed performance
Projects
None yet
Development

No branches or pull requests

1 participant