Fixes for issue #94... #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[mengel@fifeutilgpvm01 2022_08_26_142625.bda07eeb-c497-4790-a5f9-c736dc144bfe]$ jobsub_q -G fermilab -nobatch -dag 792@jobsubdevgpvm01.fnal.gov -- Schedd: jobsubdevgpvm01.fnal.gov : <131.225.240.23:9615?... @ 08/26/22 14:27:02 ID OWNER/NODENAME SUBMITTED RUN_TIME ST PRI SIZE CMD 792.0 mengel 8/26 14:26 0+00:00:35 R 0 0.0 dagman_wrapper. 794.0 |-WORKER_0 8/26 14:26 0+00:00:00 I 0 0.0 simple.sh --fin 795.0 |-WORKER_1 8/26 14:26 0+00:00:00 I 0 0.0 simple.sh --fin 796.0 |-WORKER_2 8/26 14:26 0+00:00:00 I 0 0.0 simple.sh --fin 797.0 |-WORKER_3 8/26 14:26 0+00:00:00 I 0 0.0 simple.sh --fin 798.0 |-WORKER_4 8/26 14:26 0+00:00:00 I 0 0.0 simple.sh --fin
|
Note there look to be a lot of test changes, but it's just tagging the tests as "unit" or "integration" (== slow) |
shreyb
requested changes
Aug 29, 2022
There was a problem hiding this comment.
A few things to summarize overall:
- I think there's a mistake in simple.cmd
- Aside from that, I had a couple of questions outside of the tests, which are in the various comments
- The tests stuff looks good. I've left comments to see what you think, but I like the overall idea of what you've done here, and have only general, "philosophical" questions about unit test vs integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several DAG issues in #94 that this resolves: