-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Variables subcommands for listing and deleting variables #16
Merged
radu-matei
merged 3 commits into
fermyon:main
from
kate-goldenring:variables-list-delete
Jun 6, 2023
Merged
Add Variables subcommands for listing and deleting variables #16
radu-matei
merged 3 commits into
fermyon:main
from
kate-goldenring:variables-list-delete
Jun 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49115dc
to
670a45e
Compare
fibonacci1729
approved these changes
Jun 5, 2023
kate-goldenring
commented
Jun 5, 2023
Update to latest cloud-openapi Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
4cb119a
to
b4e2976
Compare
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
b4e2976
to
2a7b074
Compare
radu-matei
approved these changes
Jun 6, 2023
.collect::<Result<Vec<Variable>, _>>() | ||
.context("could not parse variable")?; | ||
for v in var_names { | ||
println!("{}", v.key); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking this PR, but do we want to format a table head? For example, the output for the templates list command:
+------------------------------------------------------------------------+
| Name Description |
+========================================================================+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
list
anddelete
subcommands to thevariables
CLIAlso, hides the
variables
subcommand and--variable
deploy flag. Can unhide when we release the feature