Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variables subcommands for listing and deleting variables #16

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

kate-goldenring
Copy link
Collaborator

@kate-goldenring kate-goldenring commented Jun 4, 2023

Adds list and delete subcommands to the variables CLI

Also, hides the variables subcommand and --variable deploy flag. Can unhide when we release the feature

@kate-goldenring kate-goldenring marked this pull request as ready for review June 5, 2023 14:30
Update to latest cloud-openapi

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
.collect::<Result<Vec<Variable>, _>>()
.context("could not parse variable")?;
for v in var_names {
println!("{}", v.key);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking this PR, but do we want to format a table head? For example, the output for the templates list command:

+------------------------------------------------------------------------+
| Name                Description                                        |
+========================================================================+

@radu-matei radu-matei merged commit ade5fba into fermyon:main Jun 6, 2023
8 checks passed
@kate-goldenring kate-goldenring deleted the variables-list-delete branch June 6, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants