Add command for managing key value stores and links #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Dec 7, 2023
src/commands/key_value.rs
Outdated
| .get_key_value_stores(None) | ||
| .await | ||
| .with_context(|| format!("Error listing key value stores '{}'", self.name))?; | ||
| let found = list.iter().find(|kv| kv.name == self.name); |
There was a problem hiding this comment.
Would it make sense to eventually have an endpoint to find a store by name so that we don't have to fetch all stores?
There was a problem hiding this comment.
I agree. Lets add this in a later iteration, though
| r#"Database "{}" is now linked to app "{}" with the label "{}""#, | ||
| self.database, self.app, self.label | ||
| .map(|s| ResourceLinks::new(s.name, s.links)) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
Nit: you can avoid collecting this into a Vec if you change the link function to take an impl Iterator<Item = ResourceLink>
There was a problem hiding this comment.
If i pass an iterator to link the first search of any will consume part of the iterator corrupting it for other analysis later in the function
There was a problem hiding this comment.
You can use by_ref on Iterator to avoid this.
kate-goldenring
force-pushed
the
kv-links
branch
from
8ad5015
to
dab125f
Compare
kate-goldenring
force-pushed
the
kv-links
branch
2 times, most recently
from
5054756
to
82ba5b7
Compare
rylev
approved these changes
Jan 15, 2024
kate-goldenring
force-pushed
the
kv-links
branch
3 times, most recently
from
6533c2f
to
69d3b0b
Compare
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
kv-links
branch
from
69d3b0b
to
c4d0aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until changes are merged in fermyon/cloud-openapi#11
Aims to reuse as much logic and keep error formatting consistent via the
link_utilsmodule.