Use version variable for download URLs #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
use-version-variable
branch
from
7f6318f
to
8513c81
Compare
vdice
approved these changes
Nov 13, 2023
|
Looks like brew test-bot is somehow not realizing this is a tap anymore and is trying to install the homebrew core Previously didn't happen: https://github.com/fermyon/homebrew-tap/actions/runs/6828962688/job/18574160348#step:8:36 This is a known issue that has a pending fix in brew: Homebrew/brew#16216 We may consider not pointing at brew master or we can wait for that to merge |
|
Looks like the upstream issue is already merged. Do we need to wait for a release -- or just retrigger the action? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies updating a formula to only be resetting hashes. May prevent nitty errors in the future