fix: update HTTP routing to longest matching prefix wins #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #1098 |
lann
approved these changes
Feb 6, 2023
|
Docs should be updated to match |
itowlson
requested changes
Feb 6, 2023
itowlson
reviewed
Feb 6, 2023
fibonacci1729
force-pushed
the
lmp-wins
branch
from
bc178f9
to
639d154
Compare
Signed-off-by: Brian H <brian.hardock@fermyon.com>
fibonacci1729
force-pushed
the
lmp-wins
branch
from
639d154
to
ad27dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, HTTP routing in Spin is dependent upon the ordering of component configs in
spin.toml. This PR evolves the HTTP routing algorithm to longest matching prefix wins where exact matches take highest precedence followed by longest matching wildcard patterns.test_routeris updated in place to reflect the new algorithm.Signed-off-by: Brian H brian.hardock@fermyon.com