ci(perf): Improve job parallelization and disable incremental Rust builds #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incremental builds aren't useful in CI, because there will never be additional builds in the same environment with only slight changes to code. At the same time, they impose a certain amount of time overhead, and consume lots of disk space. Since we sometimes run out of disk space on GH Actions Windows runners, in particular that latter aspect is relevant here. Signed-off-by: Till Schneidereit <till@tillschneidereit.net>
The test-rust job doesn't actually require anything from the build-rust job, since it uses debug builds, but the build-rust job builds release ones. Removing this dependency should hopefully improve our wallclock time for CI runs. Signed-off-by: Till Schneidereit <till@tillschneidereit.net>
tschneidereit
force-pushed
the
ci-perf
branch
from
deedabb
to
a2a9737
Compare
rajatjindal
approved these changes
Feb 6, 2023
|
While this seems like an improvement, it unfortunately doesn't always decrease the wallclock time of CI runs too much: We could parallelize the step of building the tests container with Anyway, this seems like strictly an improvement, so I think landing it for now makes sense :) |
endocrimes
approved these changes
Feb 6, 2023
|
I believe the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes should hopefully make our CI runs take less time. More importantly, the first one, disabling incremental cargo builds, should also reduce disk usage enough to make Windows tests pass more reliably, and give us a bit more time before we have to move things to another partition ...