Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement basic template tags #1119

Merged
merged 1 commit into from
Feb 13, 2023
Merged

feat: implement basic template tags #1119

merged 1 commit into from
Feb 13, 2023

Conversation

fibonacci1729
Copy link
Contributor

This PR implements "template tags" to improve discoverability.

Signed-off-by: Brian H brian.hardock@fermyon.com

itowlson
itowlson reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realise this is a draft and I hope these comments are not premature - please feel free to ignore them if you are still changing things.

As you'll see, I am having second thoughts about what we chatted about yesterday, but only in the most milquetoast of ways - I'm still happy for you to go ahead doing it this way, just wanted to capture my thoughts in a comment.

templates/static-fileserver/metadata/spin-template.toml Outdated Show resolved Hide resolved
src/commands/templates.rs Outdated Show resolved Hide resolved
src/commands/templates.rs Outdated Show resolved Hide resolved
src/commands/templates.rs Outdated Show resolved Hide resolved
src/commands/templates.rs Outdated Show resolved Hide resolved
@fibonacci1729 fibonacci1729 reopened this Feb 7, 2023
@fibonacci1729 fibonacci1729 marked this pull request as ready for review February 8, 2023 18:21
itowlson
itowlson requested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm delighted with this - thank you!

But... and I am really sorry about this... I think the new filtering stuff does need some unit-ish tests. But the actual code is really nice! I love that you got support into new/add, and it's all super clear to read.

src/commands/templates.rs Show resolved Hide resolved
@fibonacci1729 fibonacci1729 force-pushed the template-tags branch 3 times, most recently from a868fb4 to b049eec Compare February 10, 2023 15:52
itowlson
itowlson approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good - thanks for adding them. I left one stylistic niggle but it's not a big deal - good to go! :shipit:

crates/templates/src/manager.rs Outdated Show resolved Hide resolved
@fibonacci1729
feat: implement basic template tags
3659efa 
Signed-off-by: Brian H <brian.hardock@fermyon.com>
@fibonacci1729 fibonacci1729 merged commit 3211ee5 into fermyon:main Feb 13, 2023
@fibonacci1729 fibonacci1729 deleted the template-tags branch February 13, 2023 15:55
@vdice vdice mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fibonacci1729 @itowlson