-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spin up from oci registry #1146
Conversation
54006a0
to
8f8cb6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core spin up
functionality looks fine - the request changes is for some peripheral stuff and UX bikeshedding.
a71ce99
to
40334fd
Compare
Signed-off-by: Brian H <brian.hardock@fermyon.com>
40334fd
to
e9898f5
Compare
Signed-off-by: Brian <brian.hardock@fermyon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks!
Not sure why the integration test is failing - the help output looks okay to me... 🤔 |
WIP-ishNOTE: this PR hides bindle commands / related flags on up