Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spin up from oci registry #1146

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

fibonacci1729
Copy link
Contributor

@fibonacci1729 fibonacci1729 commented Feb 14, 2023

WIP-ish

NOTE: this PR hides bindle commands / related flags on up

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core spin up functionality looks fine - the request changes is for some peripheral stuff and UX bikeshedding.

crates/trigger/src/cli.rs Outdated Show resolved Hide resolved
src/bin/spin.rs Outdated Show resolved Hide resolved
crates/trigger/src/cli.rs Outdated Show resolved Hide resolved
src/commands/up.rs Outdated Show resolved Hide resolved
src/commands/up.rs Outdated Show resolved Hide resolved
src/commands/up.rs Outdated Show resolved Hide resolved
src/commands/up.rs Outdated Show resolved Hide resolved
src/commands/up.rs Show resolved Hide resolved
@fibonacci1729 fibonacci1729 force-pushed the spin-up-from-oci branch 2 times, most recently from a71ce99 to 40334fd Compare February 15, 2023 16:35
Signed-off-by: Brian H <brian.hardock@fermyon.com>
Signed-off-by: Brian <brian.hardock@fermyon.com>
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@fibonacci1729 fibonacci1729 merged commit 556baf0 into fermyon:main Feb 15, 2023
@itowlson
Copy link
Contributor

Not sure why the integration test is failing - the help output looks okay to me... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants