add e2e tests for php, swift, oci, longevity #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatjindal
force-pushed
the
more-tests-2
branch
2 times, most recently
from
7356776
to
064851c
Compare
vdice
reviewed
Mar 1, 2023
rajatjindal
force-pushed
the
more-tests-2
branch
4 times, most recently
from
4603b36
to
a0d365f
Compare
vdice
reviewed
Mar 2, 2023
rajatjindal
force-pushed
the
more-tests-2
branch
6 times, most recently
from
7c45978
to
78a9cd9
Compare
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
rajatjindal
force-pushed
the
more-tests-2
branch
from
78a9cd9
to
a15fcfa
Compare
vdice
approved these changes
Mar 3, 2023
| } | ||
|
|
||
| #[tokio::test] | ||
| #[ignore] // https://github.com/fermyon/spin/issues/1210 |
There was a problem hiding this comment.
I think it should function if the '/index.php' path is used (#1210 (comment))?
Anyways, follow-up material when ready!
There was a problem hiding this comment.
yes, i want to update the template for php to make it work out of the box without having to have explicit index.php. in a follow up PR
yeah this one was fun to investigate and implement. I actually pulled it in a separate repo also. will publish a crate when I have some bandwidth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers following:
php,pythonandswifttemplates.phptest is disabled right now due tohttp-phptemplate not working with latest spin #1210ocilongevitytest. Idea is we check-inwasmfiles and they should continue to work with future version's ofspinandFermyon Cloud