Add key/value end to end test #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
|
I just did a quick scan, and it looks good so far. General question: Why is this an end-to-end test as opposed to an integration test? I understand why the Postgres, MySQL, and Redis tests need to be end-to-end, since they require external dependencies, but I'm not seeing anything this test does that the existing integration test (https://github.com/fermyon/spin/tree/main/tests/http/key-value) can't do. |
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
rajatjindal
reviewed
Mar 3, 2023
| async fn checks( | ||
| metadata: AppMetadata, | ||
| _: Option<BufReader<ChildStdout>>, | ||
| _: Option<BufReader<ChildStderr>>,) -> Result<()> { |
rajatjindal
approved these changes
Mar 3, 2023
|
Hi @kate-goldenring i have merged this PR as there is a pending PR I need to rebase with changes done here. |
jpflueger
pushed a commit
to jpflueger/spin
that referenced
this pull request
Mar 3, 2023
* Add key-value end to end test Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com> * Share key-value test across integration and e2e tests Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com> --------- Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com> Signed-off-by: Justin Pflueger <justin.pflueger@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test case to test the functionality of the key/value Rust SDK. The test checks both inter and intra request key/value actions.
Also, updated some of the README with the latest test suite changes and added ability to test http requests of all methods (not just
GET).