Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Change EnvProvider prefix from SPIN_APP_ to SPIN_CONFIG_ #1234

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

lann
Copy link
Collaborator

@lann lann commented Mar 6, 2023

ref #1233

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no way of knowing to what extent the config system is used; I'm wondering if for belt and braces we should temporarily accept SPIN_APP_ variables with a deprecation warning. It would complicate things rather though...!

@lann
Copy link
Collaborator Author

lann commented Mar 7, 2023

I have a pretty strong sense that it is very rarely used. Config isn't functional in cloud currently and some github searching showed no hint of it being used outside of Fermyon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants