chore: update examples and templates to spin_manifest_version #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oompf not entirely sure why |
|
Oh! I know why: spin/crates/templates/src/app_info.rs Line 12 in f0f6c5b We missed a place that uses a forked manifest schema... |
|
I think it is a "safe" failure - that is, the failed parses from the missed schema will only mean the user doesn't get a warning on a specific unhappy path. (The unhappy path will still fail, but later.) |
|
Thanks @itowlson ! I'll patch this up. |
Signed-off-by: Brian H <brian.hardock@fermyon.com>
fibonacci1729
force-pushed
the
fix-spin-tomls
branch
from
24952a8
to
164e0a4
Compare
fibonacci1729
commented
Mar 8, 2023
fibonacci1729
commented
Mar 8, 2023
itowlson
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.