Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version to v1.0.0-rc.1 #1247

Merged
merged 1 commit into from
Mar 9, 2023
Merged

update version to v1.0.0-rc.1 #1247

merged 1 commit into from
Mar 9, 2023

Conversation

michelleN
Copy link
Member

No description provided.

@kate-goldenring
Copy link
Contributor

Do we also want to update the rust templates to point to this new rc: templates/http-rust/content/Cargo.toml and templates/redis-rust/content/Cargo.toml?

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though I think we should restrict the bump in the templates/ dir to only the SDK_VERSION update in the Makefile, if only because automation handles updating the templates per that version as part of the release process. (Most likely it should be able to function fine if we've already updated the values in the template Cargo.tml/go.mod files... but might be safe to just stick to the usual process.)

@michelleN
Copy link
Member Author

Thank you @vdice. I was curious about that. I have removed all of the version updates from the templates directory except for the Makefile.

Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants