add loading spinner to registry push/pull #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
requested changes
May 10, 2023
src/commands/registry.rs
Outdated
|
|
||
| let pb = ProgressBar::new_spinner(); |
There was a problem hiding this comment.
I am not sure what but something in this is causing my cursor to sit on the right of my terminal and flicker during the upload.
There was a problem hiding this comment.
I am noticing it too. Will look into it.
karthik2804
force-pushed
the
ux/oci_spinner
branch
2 times, most recently
from
43c4579
to
d80eec8
Compare
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
ux/oci_spinner
branch
from
d80eec8
to
3616992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dotted loading animation while the registry pushes/pulls happen to make it clearer about the progress being made.