ci(.github): discontinue use of unmaintained actions #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
michelleN
reviewed
Aug 16, 2023
| target: ${{ matrix.config.target }} | ||
| shell: bash | ||
| run: | | ||
| rustup toolchain install ${{ env.RUST_VERSION }} |
There was a problem hiding this comment.
for my own curiosity: how do you have access to the rustup binary here? does it come standard with the os?
There was a problem hiding this comment.
Yes, Rust tools like rustup and cargo come pre-installed in the GitHub runners.
michelleN
approved these changes
Aug 16, 2023
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update was motivated by the slew of deprecation warnings spotted in recent CI runs (for example, this build workflow run and this release workflow run). It turns out they all stem from the actions-rs/toolchain and actions-rs/cargo actions, which unfortunately no longer appear to be maintained (ref actions-rs/toolchain#216 and actions-rs/cargo#216).
While there may be alternative actions (such as https://github.com/dtolnay/rust-toolchain), I propose we just invoke the
rustupandcargocommands directly, seeing as how our use case is fairly straightforward.Example runs from this changeset: build and release.