Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(templates): update rust templates automation to use the crates.io versions #2221

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

vdice
Copy link
Member

@vdice vdice commented Jan 10, 2024

  • Updates rust templates during versioning automation to use the spin-sdk crate version

Tested on fork via https://github.com/vdice/spin/actions/runs/7480272473; see also bot PR vdice#9

Ref #2190

Not sure if we'd like this to fully close 2190 since Windows users may still have trouble running the rust templates from main/canary, where we'll still use the git reference for the spin-sdk.

…version of the spin-sdk

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice requested a review from itowlson January 10, 2024 21:46
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you!

@vdice vdice added this to the 2.2 milestone Jan 10, 2024
@vdice vdice merged commit f13d975 into fermyon:main Jan 10, 2024
11 checks passed
@vdice vdice deleted the ci/rust-templates-use-crates-io-version branch January 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants