feat: add base base path for HTTP applications #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
changed the title
radu-matei
commented
Feb 13, 2022
radu-matei
force-pushed
the
http-base-path
branch
from
cbb736f
to
ec36267
Compare
This commit adds the concept of an application base path, whose value gets prefixed as the matched route for all components of the application. This commit also adds default HTTP headers. Signed-off-by: Radu Matei <radu.matei@fermyon.com>
radu-matei
force-pushed
the
http-base-path
branch
from
ec36267
to
1250525
Compare
radu-matei
commented
Feb 15, 2022
|
|
||
| Ok(res) | ||
| } | ||
|
|
||
| /// The HTTP executor trait. | ||
| /// All HTTP executors must implement this trait. | ||
| #[async_trait] | ||
| pub(crate) trait HttpExecutor: Clone + Send + Sync + 'static { | ||
| async fn execute( |
There was a problem hiding this comment.
At some point, we should refactor this, since the argument list keeps growing.
fibonacci1729
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #71
close #56
This commit updates the HTTP application configuration to allow setting
a per-application base path, which will be prepended to the routes
defined by individual components.
For example, if
base = "/foo", and a componentroute = "/bar/...",that component will handle incoming requests for
/foo/bar/....This is the first step in implementing #40.
See doc for the HTTP headers set.
Signed-off-by: Radu Matei radu.matei@fermyon.com