Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature, go): Expose extra response properties #3669

Merged
merged 2 commits into from
May 21, 2024

Conversation

amckinney
Copy link
Collaborator

This adds support for extra properties in response types. In particular, extra properties decoded from response objects are retained and accessible via the GetExtraProperties method like so:

user, err := client.Users.Get(...)
if err != nil {
  return nil, err
}
for key, value := range user.GetExtraProperties() {
  fmt.Printf("Got extra property; key: %s, value: %v\n", key, value)
}

@amckinney amckinney requested a review from dsinghvi as a code owner May 21, 2024 17:34
Copy link

gitguardian bot commented May 21, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11088005 Triggered Generic High Entropy Secret 3a66125 seed/go-sdk/elevenlabs/.mock/definition/user.yml View secret
11088005 Triggered Generic High Entropy Secret 3a66125 seed/go-fiber/elevenlabs/.mock/definition/user.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@amckinney
Copy link
Collaborator Author

GitGuardian is complaining about example testdata - nothing to see here.

@amckinney amckinney merged commit befef7d into main May 21, 2024
21 of 22 checks passed
@amckinney amckinney deleted the amckinney/go/extra-properties branch May 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants