Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add custom fields to define index and error documents #16

Closed
groteworld opened this issue Jan 16, 2018 · 3 comments
Closed

Comments

@groteworld
Copy link

groteworld commented Jan 16, 2018

It would be nice to be able to define the following config so that a single page application could set them both to 'index.html'. The following config should be defaults if not provided, to not break current implementations.

custom:
  client:
    indexDocument: 'index.html'
    errorDocument: 'error.html'
@fernando-mc
Copy link
Owner

@groteworld Sounds like a decent idea to me.

Is this something you could try on your own and put in a PR for? Happy to chat here or via email/video call if you want to work on it and need guidance.

@evanseeds
Copy link
Contributor

I just submitted a pull request that implements this feature, linked above at #20

@fernando-mc
Copy link
Owner

@groteworld this is implemented in the newest version. (1.4.0)

Thanks @evanseeds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants