Add a keyPrefix option #76
Conversation
|
@Archanium this looks pretty cool. Can you do me a favor and rebase and test it again? Then I can bring it into a new version. |
There was a problem hiding this comment.
Looks great! Can you also please add a section to the README for usage? Then I can merge it and cut a new release @Archanium
| ); | ||
| if (!keyPrefix) { | ||
| this.serverless.cli.log( | ||
| `Success! Your files have been removed and your bucket has been deleted` |
There was a problem hiding this comment.
Can you add a logging statement here for if(keyPrefix)
Let's give the user clarification that files from the keyPrefix are deleted.
|
@Archanium Actually, don't worry about it. I should have asked you to do that before. I'll merge now and add that myself with the new release. |
|
Just pushed this. Should be out soon. Had to fix an issue that came up when keyPrefix was undefined but seems to work now. Thanks again! |
|
You're very welcome! :) Thanks for the rest of it! |
Background
I've got a need for the keyPrefix mentioned in #73, so this is a little attempt at adding that. :)
Proposed changes
Adding a keyPrefix option, so that it's possibly to upload files to a prefixed s3 path.
Proposed reviewers (optional)
[@ mentions of other contributors]