Fix bug with .fill bytes > 127 from other encoding

feross · Nov 7, 2016 · 4e5c452 · 4e5c452
1 parent bb6ff63
commit 4e5c452
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -1544,7 +1544,7 @@ Buffer.prototype.fill = function fill (val, start, end, encoding) {
   } else {
     var bytes = Buffer.isBuffer(val)
       ? val
-      : utf8ToBytes(new Buffer(val, encoding).toString())
+      : new Buffer(val, encoding)
     var len = bytes.length
     for (i = 0; i < end - start; ++i) {
       this[i + start] = bytes[i % len]

diff --git a/test/base64.js b/test/base64.js
@@ -44,3 +44,12 @@ test('base64: invalid non-alphanumeric characters -- should be stripped', functi
   )
   t.end()
 })
+
+test('base64: high byte', function (t) {
+  var highByte = Buffer.from([128])
+  t.deepEqual(
+    B.alloc(1, highByte.toString('base64'), 'base64'),
+    highByte
+  )
+  t.end()
+})