adventure-yunfei fix: wrong overwritting of not writable Unit8Array.from #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uint8Array
defined an unwritablefrom
property, which causes overwritting operation after changingBuffer.__proto__
fails and break script execution.e.g. failing to assign ".from" property in Chrome:
When use
buffer
with webpack, everything afterBuffer.from = ...
just gone.And e.g. failing to require
buffer
in node@4We should move "Buffer.from" assignment forward to avoid this error.
Note that this may not be reproducible on all browser. In some browsers (or node@6)
Uint8Array
doesn't have 'from', or defines a writable 'from' property.