Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/jpg is not a valid type #1

Closed
mifi opened this issue Feb 11, 2017 · 1 comment
Closed

image/jpg is not a valid type #1

mifi opened this issue Feb 11, 2017 · 1 comment

Comments

@mifi
Copy link

mifi commented Feb 11, 2017

The correct type is image/jpeg. I tried running this, and it actually gives image/png data instead, when using format=jpg. Has this ever been working?

See:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toDataURL

See also:
mifi/lossless-cut#25

@feross
Copy link
Owner

feross commented Feb 12, 2017

You are correct. This was not working before. We were only testing 'png', so this slipped through.

This is now fixed and released as 1.0.1. I also added tests to prevent a regression in the future 👍

feross added a commit that referenced this issue Feb 12, 2017
@feross feross closed this as completed in dcbe33e Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants