Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined or string port parameter #2

Merged
merged 1 commit into from
Sep 17, 2014
Merged

Conversation

marmolejo
Copy link
Collaborator

Port may be undefined or a string. In both cases, the chrome API complains

@feross
Copy link
Owner

feross commented Sep 9, 2014

Thanks for all the PRs. I'm traveling right now but I'll check out all your
PRs in a few days when I'm free. Thanks again!

On Tuesday, September 9, 2014, Zeus Gómez Marmolejo <
notifications@github.com> wrote:

Port may be undefined or a string. In both cases, the chrome API complains

You can merge this Pull Request by running

git pull https://github.com/marmolejo/chrome-dgram chrome

Or view, comment on, or merge it at:

#2
Commit Summary

  • Fix undefined or string port parameter

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#2.

Feross | blog http://feross.org/ | webtorrent http://webtorrent.io/ |
studynotes http://www.apstudynotes.org/

feross added a commit that referenced this pull request Sep 17, 2014
Fix undefined or string port parameter
@feross feross merged commit be68d7d into feross:master Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants