Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #18 from ChALkeR/execfile-fixed #18

Merged
merged 2 commits into from Jan 14, 2020

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Jan 14, 2020

Based on work by @maxogden in #16, adding another fix for Windows.
Also cleaned the branch.

Should be all good now.

This is a direct replacement to #16, basing on top of that.

Copy link
Owner

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you and @maxogden for the PRs!

@feross feross changed the title Fix security issues Merge pull request #18 from ChALkeR/execfile-fixed Jan 14, 2020
@feross feross merged commit 4975317 into feross:master Jan 14, 2020
@feross
Copy link
Owner

feross commented Jan 14, 2020

I deprecated 2.x and released this as 3.x since it might contain subtle differences in the produced zip file that I haven't had a chance to test yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants