Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there any interest in a pure es modules PR? #12

Open
mreinstein opened this issue May 2, 2020 · 4 comments
Open

is there any interest in a pure es modules PR? #12

mreinstein opened this issue May 2, 2020 · 4 comments

Comments

@mreinstein
Copy link

It would be great to publish an experimental/alpha build of hyperx that is a pure es module (no commonjs.) It's still experimental in node v14 but if we were to publish a tagged package it might enable more experimentation.

Would you be open to a PR? Happy to submit one.

@feross
Copy link
Owner

feross commented May 8, 2020

Sure, feel free to send a PR. I've never converted a package to es modules before and this is about the simplest possible package to do that on. :)

@feross feross reopened this May 8, 2020
@mreinstein
Copy link
Author

yeah, sorry for the noise of issue opening/closing. What I'm struggling with right now is the "best" way to approach this. I'm exploring how to publish code to both npm and to deno.

@mreinstein
Copy link
Author

My struggles over the "best" way have largely been resolved by all supported versions of node now understanding the ESM dialect. PR forthcoming.

@mreinstein
Copy link
Author

@feross sorry for the crazy reply delay. Let me know if you have any issues with #13

I didn't update the version field in package.json but if this PR is accepted, we should semver major bump to 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants