Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel #1

Merged
merged 2 commits into from Aug 10, 2016
Merged

Add cancel #1

merged 2 commits into from Aug 10, 2016

Conversation

dcposch
Copy link
Contributor

@dcposch dcposch commented Aug 10, 2016

@feross
Copy link
Owner

feross commented Aug 10, 2016

LGTM 👍, but:

  • Style of the private method back should match the other private methods _go.
  • Needs to be added to the readme

@dcposch
Copy link
Contributor Author

dcposch commented Aug 10, 2016

@feross done

@feross feross merged commit ea86290 into feross:master Aug 10, 2016
@feross
Copy link
Owner

feross commented Aug 10, 2016

Released as 1.1.0.

feross added a commit that referenced this pull request Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants