Changes audio rendering to WaveSurfer rendering #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is super cool, but we can't ship it in Could you re-send this as a PR to Instant.io? |
|
Also, I realize that I might have said otherwise before. But I wasn't aware it was 30kb. Sorry about changing my mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue https://github.com/feross/instant.io/issues/73. It will attempt to render any audio extensions that are not considered MediaSource compatible (like mp3).
I've tested this out on the latest chromium and iceweasel using instant.io, I don't have a saucelabs account (kinda pricey) so I was unable to run cross browser tests.
It will fallback to a normal audio element in browsers that don't support Web Audio/Canvas API.
EDIT: I should probably mention the extra library added is about 30kb (estimate)