Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chrome issue with opus webm videos #34

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Fix chrome issue with opus webm videos #34

merged 1 commit into from
Feb 19, 2018

Conversation

Chocobozzz
Copy link
Contributor

On Chromium/Chrome the media could not be loaded with webm videos that have opus audio

On Chromium/Chrome the media could not be loaded with webm videos that have opus audio
@feross feross merged commit f726cbf into feross:master Feb 19, 2018
@Chocobozzz
Copy link
Contributor Author

I'm sorry @feross but it seems this patch does not work. I think we should revert it.

Moreover this patch is not sufficient, because we could also have VP9 webm videos etc. I don't really know how to handle these different codecs with unknown videos on Chrome. Maybe we could parse the chunks to fetch the right codecs, or we could try each codec with fallback (try vp8 with opus, if there is an error try vp8 with vorbis etc). But it's clearly not ideal :/

@feross
Copy link
Owner

feross commented Feb 28, 2018

@Chocobozzz I suspected that this wouldn't really help. The fundamental problem is that we're assuming we know the codec based on nothing more than the file extension.

I implemented it this way knowing that videosteam is the proper way to to handle most videos, since it properly detects the codec, etc. (But it doesn't support anything but MP4 for now).

All other formats fallback to this guess-and-pray approach based on file extension and naively using MediaSource. All of these formats using this approach don't support seeking, either.

Not sure if there's a easy way to detect the codec that we could try. Maybe @jhiesey has an idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants