rewrite redirected POST request to a GET #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how browsers handle them and it's also specified in https://tools.ietf.org/html/rfc7231\#section-6.4.2 for 301 and 302 redirects.
|
Sorry for the delay on merging this. Just catching up on things now :) |
|
2.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers rewrite 301 and 301 redirects for POST requests to GET. This is also specified in https://tools.ietf.org/html/rfc7231\#section-6.4.2 now.
Our current implementation forgets to pass the body to the redirect on POST anyway. So it will hang, since it's only passing the
content-length, but not the body.I suggest to implement the browser's behavior as this is what most people would expect.