New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reconnection not possible #24
Comments
Just released v5.6.0 which doesn't destroy the |
testing it now, will let you know if it allows our reconnect logic to kick in |
Any update? |
Working smoothly again! In case anybody sees this later and is wondering - for reconnection set a timeout on disconnect to destroy unless connect has been emitted again. @feross What do you think about an option for this? |
@contra Yes, this should be built into simple-peer. I'm noticing that sometimes the 'disconnect' ICE state happens, but never 'closed', so the peer never fires 'close' and lives on as a zombie. Adding a timer into instant.io would allow 'close' to eventually fire and give reconnect a chance to happen. |
Hi guys! The peer connection and the data channel objects are destroyed. Thanks! |
@codealchemist, apparently not, otherwise it wouldn't be in |
Thanks for your answer @nazar-pc. Cheers! |
seems like this library treats
closed
anddisconnected
ICE states as destroyed, butdisconnected
can also mean that it was temporarily disconnected and is attempting to reconnect. we are seeing increased connection drops since switching to simple-peer since there is no way to let the peer run its natural reconnection processeshttps://github.com/feross/simple-peer/blob/master/index.js#L324
The text was updated successfully, but these errors were encountered: