Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peer.signal() should return a promise #593

Open
nazar-pc opened this issue Feb 17, 2020 · 0 comments
Open

peer.signal() should return a promise #593

nazar-pc opened this issue Feb 17, 2020 · 0 comments
Labels
feature request

Comments

@nazar-pc
Copy link
Collaborator

Since setting local or remote description is an asynchronous operation, we should probably change peer.signal() and maybe peer.negotiate() too to become asynchronous and return a Promise.
This will help in case of tweaking RTCRtpSenders after negotiation to change bitrate as a useful example. It will also match native API more closely.

Thoughts?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nazar-pc @t-mullen