fixed buggy metadata vs metadata.info #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: in addition to fixing this bug, the latest commit confirms support for torrents with multi-block metadata referenced in this issue. |
| info = bncode.encode(bncode.decode(metadata).info) | ||
| } catch (err) { | ||
| // TODO: throw or disregard invalid metadata? | ||
| //throw new Error('ut_metadata constructed with invalid metadata') |
There was a problem hiding this comment.
I think throwing an error is better than silently proceeding. If the user passes in a buffer, they think they have valid metadata. Better they get an exception and fix their code if this is not the case.
|
Awesome, thank you for making this more consistent. And especially thanks for the test that verifies that multi-block metadata is working. I knew this was working but the test will make sure it stays that way :) |
|
Published as 2.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ut_metadata.metadata has to contain only the info dictionary for properly sharing it with peers. this fixes my previous attempt to fix metadata and also fixes the ut_metadata constructor which takes in the full metadata.