Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fix impossible to delete Wired CD torrent #1013

Merged
merged 1 commit into from Oct 5, 2016
Merged

Conversation

feross
Copy link
Member

@feross feross commented Oct 5, 2016

Fixes: #905

Remove the trailing dot (.) from the Wired CD torrent name, since folders/files that end in a trailing dot (.) or space are not deletable from Windows Explorer.

@feross
Copy link
Member Author

feross commented Oct 5, 2016

Alright! Here's a PR to remove the trailing . from the WIRED torrent's name. I also added a migration so existing users with an un-deletable WIRED torrent folder in their Downloads folder will have it renamed. Now either WebTorrent or Windows Explorer can delete it for them, if they want to do that.

The real fix (preventing torrents from ending with a .) is harder to make since it changes the low-level parse-torrent-file and we currently have assumptions all throughout webtorrent and webtorrent-desktop that the torrent name and folder name on disk will match. I've never seen a torrent in the wild that ends with a ., so this should make this error basically go away. And since this is really a Windows Explorer bug, I think this solution is 💯.

@feross feross mentioned this pull request Oct 5, 2016
@feross feross changed the title Windows: Fix impossible to delete Wired CS torrent Windows: Fix impossible to delete Wired CD torrent Oct 5, 2016
@feross feross merged commit 1e10f00 into master Oct 5, 2016
@feross feross deleted the feross/fix branch October 5, 2016 10:00
@lock lock bot locked as resolved and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants