Electron 1.2.0 #587
Merged
Electron 1.2.0 #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
feross
commented
May 25, 2016
•
feross
commented
- Update to Electron 1.2.0 (Chrome 51)
- Use .ico format on Windows for best rendering quality, instead of resized .png files
- Fix crashReporter not working (Windows)
- Fix window resizing when aspect ratio is enforced (OS X)
|
Tested on OS X, works fine. Still failing on Windows, even with the newer Electron version :( |
|
See electron/electron#5629 for the reason that Windows crashes. We need to downgrade to an Electron that uses Chrome 49. |
|
New plan: wait until next Electron release that contains Chrome 51 (supposedly imminent) |
- Use .ico format on Windows for best rendering quality, instead of resized .png files
|
Updated PR to Electron 1.2.0 (Chrome 51) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.