Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generation of depended grammars #37

Closed
wants to merge 2 commits into from
Closed

Allow generation of depended grammars #37

wants to merge 2 commits into from

Conversation

ferraith
Copy link
Owner

@ferraith ferraith commented Jul 28, 2018 •
edited
Loading

Resolves #34

@ferraith ferraith added the feature New feature or request label Jul 28, 2018
@ferraith ferraith added this to the 0.3.0 milestone Jul 28, 2018
@ferraith ferraith self-assigned this Jul 28, 2018
@ferraith ferraith added this to In progress in setuptools-antlr via automation Jul 28, 2018
@coveralls
Copy link

coveralls commented Jul 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 44

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 40: 0.0%
Covered Lines: 251
Relevant Lines: 251
💛 - Coveralls

@ferraith ferraith changed the title #34: Allow generation of depended grammars Resolves #34: Allow generation of depended grammars Jul 28, 2018
@ferraith ferraith changed the title Resolves #34: Allow generation of depended grammars Allow generation of depended grammars Jul 28, 2018
@ferraith ferraith added the wontfix This will not be worked on label Jul 29, 2018
@ferraith
Copy link
Owner Author

This feature won't be implemented because there exist some redundancy between passing grammars to be generated explicitly one command line (grammars option) and implicitly allow generation of depended grammars.

Some testing was done to ensure the specification of the grammars to be generated is as simple as possible for the user:

  • If no grammars were passed with the grammars parameter all found grammars will be generated regardless of dependencies between them.
  • If grammars were passed with the grammars parameter only these grammars will be generated.

@ferraith ferraith closed this Jul 29, 2018
setuptools-antlr automation moved this from In progress to Done Jul 29, 2018
@ferraith ferraith mentioned this pull request Jul 29, 2018
Closed
@ferraith ferraith deleted the feature/dependencies-arg branch July 29, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ferraith ferraith

Labels
feature New feature or request wontfix This will not be worked on
Projects
setuptools-antlr
  
Done
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ferraith @coveralls