Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gen-packages and package-dir configurations #48

Closed
wants to merge 2 commits into from
Closed

Add gen-packages and package-dir configurations #48

wants to merge 2 commits into from

Conversation

LeboyX
Copy link

@LeboyX LeboyX commented Jan 24, 2019

The 'gen-packages' configuration is a boolean config that controls the command's recursive scan of grammar-package directories. When set to false ("no"), the tool won't add init.py files to any directories other than the grammar parsers' directory.

The 'package-dir' flag tells control what is considered the "base_dir" for the creation of init.py files. The base_dir is excluded from the creation of init.py files.

…the generation of packages in parent directories and the base dir for generated content, respectively.
@LeboyX
Copy link
Author

LeboyX commented Jan 24, 2019

Build seems to've failed due to a...version conflict(?!) for pytest, or its dependency pytest_cov. Looks like it needs a version >= 3.6, but the build only got 3.3.0. I don't think my changes could've influenced this, so I'm a little perplexed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 97

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 96: 0.0%
Covered Lines: 261
Relevant Lines: 261

💛 - Coveralls

@ferraith
Copy link
Owner

Thank you very much for your PR. I decided to completely remove this weird init file generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants