Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.4.5 recompile #226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

1.4.5 recompile #226

wants to merge 3 commits into from

Conversation

rsparkyc
Copy link

No description provided.

@blowfishpro
Copy link
Contributor

What's with all the changes to the .csproj files? Did the line endings change or something?

@rsparkyc
Copy link
Author

Oh wow, I guess VS made some whitespace changes on those (maybe tabs vs spaces) I didn't intend to make any large changes to those, just changed the paths to the dependencies

@willwill2will54
Copy link

I have been testing this. No apparent problems. I would support this merge.

@Bornholio
Copy link

Tested with Clean install 1.4.3.2152 +MM 3.0.7, did not have functioning parachutes.
Installed real chutes to have working chutes. Standard CoL indicator seemed way far down.
Otherwise seemed like everything worked.

@willwill2will54
Copy link

Ahh. Parachutes. Don't normally use those...
image

@Bornholio
Copy link

reloaded retested, must have failed to add MFI correctly. added through CKAN and issues went away. All good.

Bornholio
Bornholio approved these changes May 30, 2018
View reviewed changes
Copy link

@Bornholio Bornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@BlueNexus
Copy link

Any idea when this is getting merged?

@rsparkyc rsparkyc changed the title 1.4.3 recompile 1.4.5 recompile Aug 28, 2018
@Bornholio
Copy link

I've been running these for a while with a RSS/RO/RP-1 install, only thing I see that needs fixing is for some reason the Icons turn black in toolbar.

@atakiya atakiya mentioned this pull request Oct 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bornholio Bornholio Bornholio approved these changes

@willwill2will54 willwill2will54 willwill2will54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rsparkyc @blowfishpro @willwill2will54 @Bornholio @BlueNexus