Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sszgen): Remove redundant generated code #150

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

letonchanh
Copy link
Contributor

In the generated code, when processing the last variable field in a container, we don't need to update the offset as there is no next variable field that uses the offset.

The PR also removes redundant statements in marshalContainer.

@ferranbt
Copy link
Owner

ferranbt commented Mar 24, 2024

Hi! Thank you for the contribution.

Could you also run make build-spec-tests? To generate the code for the Ethereum consensus spec tests (CI fails without that).

@letonchanh
Copy link
Contributor Author

Hi! Thank you for the contribution.

Could you also run make build-spec-tests? To generate the code for the Ethereum consensus spec tests (CI fails without that).

Sure. Thank you for the approval.

@ferranbt ferranbt merged commit 274d5da into ferranbt:main Mar 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants