Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while breeaking leaves, BirdsNests compatibility #11

Closed
ZephaniahNoah opened this issue Oct 21, 2017 · 5 comments
Closed

Crash while breeaking leaves, BirdsNests compatibility #11

ZephaniahNoah opened this issue Oct 21, 2017 · 5 comments

Comments

@ZephaniahNoah
Copy link

I'm not sure which mod is causing this but when I install BirdsNests and try to break the dynamic leaves the game will eventually crash.
Dynamic Trees: 0.6.5
MC: 1.11.2

@ferreusveritas
Copy link
Collaborator

You got a crash log for me?

@ZephaniahNoah
Copy link
Author

@ferreusveritas
Copy link
Collaborator

Looks like the birdsnests mod is expecting my leaves to have a "decayable" property which it does not. Dynamic leaves are derived from vanilla leaves but do not decay in the same way as vanilla leaves.

The author of birdsnests might consider putting in a check for leaves in case a mod(such as mine) does the leaves a bit differently.

if (blockState.getProperties().containsKey(DECAYABLE)) {
// do leafy stuff here
}

For me to institute a fix on my end I would have to do a tremendous amount of work to implement a non-standard IBlockState interface to return a fake "decayable" value and I don't know if the mod would be happy with true or false.

@ferreusveritas
Copy link
Collaborator

This is on BirdsNests to fix. I've given my suggestion on how to fix it. Looks like BirdsNests hasn't been updated in a while so I don't foresee this being fixed.

@ferreusveritas
Copy link
Collaborator

This has been fixed by cleverpanda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants