Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let crate build in non-cargo build systems #162

Closed
wants to merge 2 commits into from

Conversation

rocallahan
Copy link

No description provided.

@myrrlyn myrrlyn closed this in 8dcc6e9 Jul 1, 2022
@myrrlyn
Copy link
Collaborator

myrrlyn commented Jul 1, 2022

Because String is not available in core-only targets, this commit as written does not compile. However, you are correct in that using env! is an unnecessary restriction. Therefore, I will be writing my own patch to address this.

I apologize for the delay, and thank you for bringing this to my attention.

@rocallahan rocallahan deleted the non-cargo branch July 2, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants