Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync x86_64-unknown-linux-gnu settings file with upstream #634

Merged
merged 1 commit into from
Jun 5, 2024
Merged

sync x86_64-unknown-linux-gnu settings file with upstream #634

merged 1 commit into from
Jun 5, 2024

Conversation

tshepang
Copy link
Member

No need to carry the diff since upstream also moved the target to use lld by default.

@tshepang
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request May 20, 2024
@bors-ferrocene
Try #634:
d223f49
@bors-ferrocene
Copy link
Contributor

try

Build succeeded:

@pietroalbini
Copy link
Member

Have we checked CFG_USE_SELF_CONTAINED_LINKER is actually set by our CI?

@pietroalbini
Copy link
Member

Also, there are more changes to revert from #100.

@tshepang
Copy link
Member Author

tshepang commented May 20, 2024 •
edited

CFG_USE_SELF_CONTAINED_LINKER is set automatically when --enable-lld is used, which we do in configure.sh (unless am not reading it well)

@tshepang
Copy link
Member Author

Also, there are more changes to revert from #100.

the upstream change affects just x86_64-unknown-linux-gnu

@pietroalbini
Copy link
Member

We should still keep the coretest target consistent.

@tshepang
sync x86_64-unknown-linux-gnu settings file with upstream
ad85980 
No need to carry the larger diff since upstream also moved the target to
use lld by default.
pietroalbini
pietroalbini approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors-ferrocene bot added a commit that referenced this pull request Jun 3, 2024
@bors-ferrocene @tshepang
Merge #634
55db26f 
634: sync x86_64-unknown-linux-gnu settings file with upstream r=pietroalbini a=tshepang

No need to carry the diff since upstream also moved the target to use lld by default.

Co-authored-by: Tshepang Mbambo <tshepang.mbambo@ferrous-systems.com>
@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Jun 3, 2024

Build failed:

  • full

@tshepang
Copy link
Member Author

tshepang commented Jun 5, 2024

bors retry

@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Jun 5, 2024

Build succeeded:

  • full

@bors-ferrocene bors-ferrocene bot merged commit d32c7fe into main Jun 5, 2024
3 checks passed
@bors-ferrocene bors-ferrocene bot deleted the tshepang-remove-diff branch June 5, 2024 17:05
@github-actions github-actions bot added the backport:maybe PR candidate for backport label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini approved these changes

Assignees
No one assigned
Labels
backport:maybe PR candidate for backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tshepang @pietroalbini