Monkey patch sphinx SortIDs transform to sort our own IDs #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urhengulas
reviewed
Jun 18, 2024
Veykril
force-pushed
the
sort-id-fix
branch
2 times, most recently
from
f16c00e
to
c39b2ac
Compare
|
CI fails due to #505 |
Veykril
force-pushed
the
sort-id-fix
branch
2 times, most recently
from
541fb90
to
25320f6
Compare
|
I'm not too thrilled with the monkey patching approach. If we want to guarantee that the FLS ID is always the first ID, we should add our own transform that moves it to the front. |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some anchoring inconsistencies and also makes link check correctly work for section id <-> other id collisions, see 3cf79ed which CI did not catch so far, now it will. cc ferrocene/ferrocene#699 which broke because of the collision