Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unsigned 64-bit integers for sequence numbers #108

Closed
JohnGreenan opened this issue Mar 15, 2023 · 2 comments
Closed

Support unsigned 64-bit integers for sequence numbers #108

JohnGreenan opened this issue Mar 15, 2023 · 2 comments

Comments

@JohnGreenan
Copy link

Is your feature request related to a problem? Please describe.
Per https://www.fixtrading.org/groups/continuousmkts/
Sequence number resets are a bore.

Describe the solution you'd like
The implementation proposed is to use an unsigned 64 bit integer for a sequence number.

Using 1 billion sequence numbers per second, that will last for 584 years until they run out.

So we can leave the problem to our great, great, great (more) grandchildren to solve!

Describe alternatives you've considered
delete_me

See attached "Continuous Markets WG- 24x7 FIX Best Practise Working Draft_v0.015.docx"
Continuous Markets WG- 24x7 FIX Best Practise Working Draft_v0.015.docx

It looks like the use of usize for the datatype of BeginSeqNum and EndSeqNum in ResendRequest message means that these are 64 bit unsigned integers if complied on any modern 64-bit architecture.

Can you confirm this understanding is correct, that there is no need to change ferrumfix?

@neysofu
Copy link
Member

neysofu commented Jul 29, 2023

This is correct, FerrumFIX has support for 64-bit sequence numbers (in fact, it doesn't support anything other than 64-bit counters)!

@neysofu neysofu closed this as completed Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants