Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiry And Withdraw Message Management #34

Conversation

SibghatUllah1997
Copy link
Contributor

Commit Overview

This commit introduces an important update to our fund manager, particularly focusing on the withdrawal process. We've implemented an expiry mechanism for withdrawal signatures and ensured that during withdrawals, the amountIn parameter is treated as the FR balance.

Key Changes

  1. Expiry Mechanism for Withdrawal Signatures:

    • Added a time-sensitive validity to withdrawal signatures in the fund management system. This expiry feature is designed to enhance security, preventing outdated or stale signatures from being used maliciously or erroneously.
    • The expiry logic ensures that a withdrawal signature is only valid for a predetermined duration, after which it cannot be used for withdrawal operations.
  2. amountIn as FR Balance on Withdrawal:

    • Modified the withdrawal logic to treat the amountIn parameter as the FR balance. This change aligns the withdrawal amounts more closely with the actual available resources, ensuring accuracy and consistency in fund management.
    • This adjustment addresses potential issues where the withdrawal amount could previously be misaligned with the actual FR balance, leading to discrepancies or errors in fund accounting.

Impact and Benefits

  • Enhanced Security: The implementation of an expiry mechanism for withdrawal signatures significantly reduces the risk of unauthorized or fraudulent fund access.
  • Improved Accuracy: By considering amountIn as the FR balance, we eliminate inconsistencies between withdrawal requests and available resources, ensuring that withdrawals accurately reflect the fund's current state.
  • Streamlined Operations: These changes streamline the withdrawal process, making it more straightforward and user-friendly for fund managers and clients alike.

@zikriya zikriya merged commit 5dfb7ab into ferrumnet:feature/NonUpgradeable Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants