Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCTP Finalisation #49

Open
wants to merge 101 commits into
base: develop
Choose a base branch
from
Open

Conversation

salmanferrum
Copy link
Contributor

This PR removes the logic of using two FundManagers from the backend script. The following changes were made:

  • Removed CCTPFundManager related code.
  • Removed the logic for detecting when to use FundManager or CCTPFundManager.
  • Removed the cctpType parameter from withdrawal functions as it's no longer needed.
  • This simplifies the FiberRouter and removes unnecessary complexity related to the CCTPFundManager.

Additionally, the integration script is also updated to include the following flow:

  • Determines CCTP type based on the logic for checking balance of FundManager on the target network.
  • Performs either the normal flow or the CCTP flow accordingly.
  • Call Swap functions
  • Incase of CCTP Flow, Calls the circleAttestation function to perform withdrawal to the FundManager of the target network.
  • Then, Calls withdrawSigned and withdrawSignedAndSwapRouter functions after the attestation is completed.

Copy link

@lukmaan-k lukmaan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

* @param _targetNetworkDomain The domain of the target network.
* @param _targetCCTPFundManager The fund manager address for the target network.
*/
function setTargetCCTPNetwork(uint256 _chainID, uint32 _targetNetworkDomain, address _targetCCTPFundManager) external {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No access control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants