Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions for Building and installing contracts #6

Merged
merged 1 commit into from
May 29, 2023
Merged

Instructions for Building and installing contracts #6

merged 1 commit into from
May 29, 2023

Conversation

tyshkor
Copy link
Contributor

@tyshkor tyshkor commented May 29, 2023

Instructions for Building and installing contracts added to README.md files

salmanferrum
salmanferrum reviewed May 29, 2023
View reviewed changes
Copy link
Collaborator

@salmanferrum salmanferrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add the version of rust, version of casper crate and other dependencies version that works for us. This way, they will have good idea on how to run the code smoothly without going back and forth.

@tyshkor
Copy link
Contributor Author

tyshkor commented May 29, 2023

It would be nice to add the version of rust, version of casper crate and other dependencies version that works for us. This way, they will have good idea on how to run the code smoothly without going back and forth.

Rust is installed automatically with the version in the rust-toolchain, same thing for the dependencies, therefore this information is not needed.

@tyshkor tyshkor requested a review from salmanferrum May 29, 2023 08:04
@zikriya zikriya merged commit 808787e into ferrumnet:develop May 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salmanferrum salmanferrum salmanferrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyshkor @salmanferrum @zikriya